-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump size default from 5 to 20 #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmquinn - we had decided to raise size but to still only return 5 though so the UI wouldn't have to change.
Here's the issue: https://github.com/nulib/repodev_planning_and_docs/issues/5178
@kdid I think this change should probably include a test, this PR or a separate one you think? |
A test is always welcome, but it doesn't look like we were testing doc counts before so I'm OK with it not being in this PR - your call. I would like to see all 20 documents in the metrics though so we know the full context of what the LLM reasoned with. I'm fine if they are in the existing field, as long as it's in order. (Or if it's easier to do an additional field I'm fine with that too.) |
Thanks for the suggestion, and I totally agree. I'll work on adding that right away and push a new commit. |
size
to 205
over the Websocket connection