Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump size default from 5 to 20 #252

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

bmquinn
Copy link
Contributor

@bmquinn bmquinn commented Aug 23, 2024

  • Sets the default size to 20
  • Limits source document count to 5 over the Websocket connection

Copy link
Contributor

@kdid kdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmquinn - we had decided to raise size but to still only return 5 though so the UI wouldn't have to change.

Here's the issue: https://github.com/nulib/repodev_planning_and_docs/issues/5178

@bmquinn
Copy link
Contributor Author

bmquinn commented Aug 23, 2024

@kdid I think this change should probably include a test, this PR or a separate one you think?

@kdid
Copy link
Contributor

kdid commented Aug 26, 2024

A test is always welcome, but it doesn't look like we were testing doc counts before so I'm OK with it not being in this PR - your call.

I would like to see all 20 documents in the metrics though so we know the full context of what the LLM reasoned with. I'm fine if they are in the existing field, as long as it's in order. (Or if it's easier to do an additional field I'm fine with that too.)

Screenshot 2024-08-26 at 7 19 58 AM

@bmquinn
Copy link
Contributor Author

bmquinn commented Aug 26, 2024

Thanks for the suggestion, and I totally agree. I'll work on adding that right away and push a new commit.

@bmquinn bmquinn requested review from kdid and mbklein August 26, 2024 19:07
@bmquinn bmquinn merged commit 730c6ca into deploy/staging Aug 26, 2024
1 check passed
@bmquinn bmquinn deleted the 5178-increase-query-size-value branch August 26, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants