Reimplement shared links handler #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document and get the target work document regardless of visibility/published status.
mbklein
approved these changes
Oct 21, 2022
| }; | ||
|
|
||
| const linkExpired = (expirationDate) => { | ||
| return !isValid(expirationDate) || expirationDate <= new Date(); |
There was a problem hiding this comment.
It occurs to me that the request will be denied if it hits this line right at the last millisecond that the link is valid due to the <=. I'm not inclined to change it, though. We'll deal with any complaints that come in. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the /shared-links/{id} handler to parse a shared links document and get the target work document regardless of visibility/published status.