Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/configure eslint and husky #84

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Jan 27, 2023

  • Add eslint as an explicit dependency
  • Add eslintConfig section to package.json
  • Use husky to run eslint & prettier before commit
  • Fix all eslint complaints in the existing codebase

The vast majority of existing complaints from the linter were about variables that were either declared/assigned but unused, or undeclared (i.e., missing let or const before first assignment).

You can always use the --no-verify flag on a git commit to skip the pre-commit hook if you're confident and willing to live with the consequences. 😄

Use husky to run eslint & prettier on commit
@mbklein mbklein merged commit 7c747c5 into deploy/staging Jan 28, 2023
@mbklein mbklein deleted the lint-fix-precommit branch January 28, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants