-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Generates False-Positives #72
Comments
When using
relating to the following code
See the complete patient.txt, lines 1315-1324 and lines 1355-1360, respectively. |
Reopening this issue due to additional false positive validation errors. |
We get follwing errors, when we validate our fhir bundle (only for testing purpose):
|
@taneroksuz Based on my understanding I am classifying the first two errors as false positive.
|
In addition to the code
|
We are getting the following validation error:
However, the UCUM specification (https://ucum.org/ucum.html) states: "§6 curly braces ■1 The full range of characters 33–126 can be used within a pair of curly braces (‘{’ and ‘}’). The material enclosed in curly braces is called annotation. ■2 Annotations do not contribute to the semantics of the unit but are meaningless by definition. Therefore, any fully conformant parser must discard all annotations. Parsers of limited conformace should not value annotations in comparison of units. ■3 Annotations do, however, signify the end of a unit symbol. ■4 An annotation without a leading symbol implies the default unit 1 (the unity). ■5 Curly braces must not be nested". Is that a known issue? |
Hi @eicherj, the GECCO profile Respiratory Rate has a validation rule for Since
the UCUM specification is ignored. Based on the current Respiratory Rate profile, the validation error you mentioned above is not a false-positive, but rather a result of the way the GECCO profile is defined. The validator from simplifier.net seems to agree with this assessment. @julsas Any thoughts on changing Respiratory Rate and other profiles? I think in order to allow annotations in units we would need to remove the fixedPattern rules and add bindings to specific ValueSets. These ValueSets would then include one or multiple entries from the http://unitsofmeasure.org CodeSystem. |
@hhund @eicherj |
|
We had an error when validating Blood-Gas-Panel resources through the DSF. The error always looked like this:
Solution:
The structure definition is reloaded and everything works fine now. |
This is still an issue? Sounds related to the snapshot generator problem. Snapshot for this extension can be obtained from here: https://simplifier.net/packages/de.medizininformatikinitiative.kerndatensatz.laborbefund/1.0.6/files/388075 @hhund to fix this, couldn't the framework install the StructureDefs with pre-generated snapshots instead of using HAPI's snapshot generator? |
The false positive validation error about the As of today (2022-08-31 17:30) both production and the pre-prod (test) deployments have been fixed via a special release of the FHIR Bridge. The issue is otherwise being tracked at ehrbase/fhir-bridge#581 |
Effected process plugin version: 0.5.0
Due to an error in the StructureDefinition snapshot generator of HAPI 5.1.0, the validator produces false-positive errors. Effected StructureDefinitions validation rules from
de.gecco|1.0.5
and its depended implementation guides are:https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/pH|1.0.4
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/carbon-dioxide-partial-pressure|1.0.4
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/oxygen-partial-pressure|1.0.4
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/inhaled-oxygen-concentration|1.0.4
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/diabetes-mellitus|1.0
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/organ-recipient|1.0
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/symptoms-covid-19|1.0
A fix already exists for the following rule in the 0.5.0 release of the process plugin:
https://www.netzwerk-universitaetsmedizin.de/fhir/StructureDefinition/radiology-procedures|1.0.5
Root cause of the false-positive validation errors are wrong generated "min = X" (for X != 0) rules in the StructureDefinition snapshot for slicing rules without a "min" definition where the slicing definition (incl. discriminator) is not part of the same profile but rather defined in the base profile.
The fix will include identifying bad profile rules and adding a
min 0
where appropriate. Similar to the existing fix:codex-processes-ap1/codex-process-data-transfer/src/main/java/de/netzwerk_universitaetsmedizin/codex/processes/data_transfer/validation/structure_definition/GeccoRadiologyProceduresCodingSliceMinFixer.java
Lines 15 to 31 in f5aaa4e
The text was updated successfully, but these errors were encountered: