-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/0.6.0 #88
Merged
Merged
Release/0.6.0 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issues/72_Validator_Generates_False-Positives
Code cleanup in ValidateDataLearningTest
Modified the code to only add concepts that are missing based on no other entry with the same system and code existing in the expansion. The previous implementation also compared code-system version resulting in duplicate entries, if the terminology server did not include the version but the definition did or vice versa.
there won't be a version 0.5.2, 0.6.0 will include fixed false-positive validation errors and additional changes to the process
For example the following ValueSet are missing from the de.gecco|1.0.5 validation package and its dependencies: * http://hl7.org/fhir/uv/ips/ValueSet/laboratory-tests-and-panels-uv-ips * http://loinc.org/vs/LL738-6 * https://fhir.kbv.de/ValueSet/KBV_VS_MIO_Vaccination_TargetDisease * https://fhir.kbv.de/ValueSet/KBV_VS_SFHIR_ICD_DIAGNOSESICHERHEIT * https://fhir.kbv.de/ValueSet/KBV_VS_SFHIR_ICD_SEITENLOKALISATION
'origin/issues/72_Validator_Generates_False-Positives' into develop
Logging off search, result and transfer bundles is now disabled by default and can be enable using the config parameter `de.netzwerk.universitaetsmedizin.codex.gecco.dataLoggingEnabled` Also fixes a small issue with resource IDs not visible in log messages generated by the ReadData class, due to a bad order of operations. Resource IDs are now logged as absolute IDs.
The data-send process can now be instructed to perform a dry-run only using the optional input-parameter "dry-run" with a value of "true". A dry-run will abort the data-send process after validation end enryption of the transfer bundle but before the bundle is stored in the local DSF FHIR server and a Task to start the data-translate process is send to the GECCO Transfer Hub.
Added new process version environment variable to generated .env file. PROCESS_VERSION environment variable now used in process exclude config in docker-compose file.
The pattern **/*LearningTest.java is used to exclude learning tests.
Changes to the Task resource need to be stored in the leading task process variable since it is the only one that survives the return task restarting the process via the intermediate message throw events. The start-data-translate process Task now shows the size (in bytes) of the encrypted transfer bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #72
closes #77
closes #79
closes #80
closes #81
closes #86