Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/39 internal bundle validation #68

Merged
merged 31 commits into from
Jun 18, 2022

Commits on May 24, 2022

  1. changed restart policy to "no", DSF version to 0.6.0

    restart policy "no" makes it easier to debug issues related to crashing
    containers
    hhund committed May 24, 2022
    Configuration menu
    Copy the full SHA
    564a931 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    978c6bc View commit details
    Browse the repository at this point in the history
  3. initial validation impl., demo data now compliant with gecco 1.0.5 spec

    This initial process validation task implementation requires 29
    additional jars to be added to the BPE as regular (non-process) plugins.
    Alternatively we could release the process plugin as a tar.gz/zip or we
    might want to add the needed HAPI dependencies into the DSF BPE itself.
    This implementation  contains some workarounds due to limitations of
    some classes in the dsf-fhir-validation module.
    
    The maven build produces a
    codex-process-data-transfer-0.5.0-SNAPSHOT.zip containing the
    codex-process-data-transfer-0.5.0-SNAPSHOT.jar and all dependency needed
    to start a stand-alone bundle/resource validator.
    
    Windows:
    java -cp codex-process-data-transfer-0.5.0-SNAPSHOT.jar;lib/*
    de.netzwerk_universitaetsmedizin.codex.processes.data_transfer.validation.ValidationMain
    some-bundle.json some-resource.xml
    
    Unix:
    java -cp codex-process-data-transfer-0.5.0-SNAPSHOT.jar:lib/*
    de.netzwerk_universitaetsmedizin.codex.processes.data_transfer.validation.ValidationMain
    some-bundle.json some-resource.xml
    
    The stand-alone validator outputs debug infos to System.err and the
    validation result to System.out. For a given single resource a
    OperationOutcome resource is produced and for a given Bundle, a bundle
    with added response.outcome per entry with be printed to System.out.
    The validator validates every json or xml file defined as command line
    argument.
    The validator can be configured using a application.properties file
    within the execution folder or via java system properties, meaning java
    command line parameters -Dfoo=bar. For configuration properties see
    classes
    de.netzwerk_universitaetsmedizin.codex.processes.data_transfer.spring.config.ValidationConfig
    and
    de.netzwerk_universitaetsmedizin.codex.processes.data_transfer.validation.ValidationMain.TestConfig.
    hhund committed May 24, 2022
    Configuration menu
    Copy the full SHA
    5da1517 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    7f16f6b View commit details
    Browse the repository at this point in the history
  2. simplified logging pattern

    hhund committed May 25, 2022
    Configuration menu
    Copy the full SHA
    be89ddb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ae6786 View commit details
    Browse the repository at this point in the history
  4. fixed client init code for trust store defined but no key store defined

    clients only initialize a trust store only ssl context, if key store and
    key store password are null.
    hhund committed May 25, 2022
    Configuration menu
    Copy the full SHA
    1666aa9 View commit details
    Browse the repository at this point in the history
  5. fixed forward proxy support, added ontology server connection test

    Jersey based clients not use the ApacheConnectorProvider. Standard
    connector provider has no support for forwarding proxies. Added a
    ontology server connection test to the ValueSetExpansionClient and usage
    of to ValidatorMain.
    hhund committed May 25, 2022
    Configuration menu
    Copy the full SHA
    5178615 View commit details
    Browse the repository at this point in the history
  6. adds profile modifier to fix GECCO radiology-procedures missing min=0

    The GECCO 1.0.5 radiology-procedures profile needs a min=0 config in the
    rule Procedure.code.coding:dicom in order for the HAPI Snapshot
    Generator to generate the correct StructureDefinition snapshot.
    hhund committed May 25, 2022
    Configuration menu
    Copy the full SHA
    d8ec317 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Added "dicom" fix to ValidationPackageManagerImpl constructor

    The contructor of ValidationPackageManagerImpl used in the
    ValidateDataLearningTest was missing the "dicom" fix, aka
    GeccoRadiologyProceduresCodingSliceMinFixer
    hhund committed May 27, 2022
    Configuration menu
    Copy the full SHA
    d47efa8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3f863a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    60362f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Merge remote-tracking branch 'origin/develop' into

    issues/39_internal_bundle_validation
    hhund committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    3f471db View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/develop' into

    issues/39_internal_bundle_validation
    hhund committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b478e14 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. renamed error CodeSystem/ValueSet, removed comments, changed log level

    Removed "-type" suffix from the error code CodeSystem/ValueSet.
    
    Removed not needed TODO comments.
    
    Changed log level from error to warning for first try ValueSet expansion
    errors (errors resulting in trying to expand via external terminology
    server next).
    
    Changed external terminology server for the test setup.
    hhund committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    dc83436 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Configuration menu
    Copy the full SHA
    e9a8c81 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. added docker-compose file to override dsf images with local builds

    To start the dic-fhir service with a locally build DSF image use:
    docker-compose -f docker-compose.yml -f
    docker-compose.local-dsf-build.yml up dic-fhir
    hhund committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2197f92 View commit details
    Browse the repository at this point in the history
  2. switched to DSF 0.7.0-SNAPSHOT, remove not needed code and dependencies

    These changes depend on highmed/highmed-dsf#354 being merged.
    hhund committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4cdaffd View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. removed not needed dependency management entries, some cleanup

    Increased version numbers of log42-utils and crypto-utils dependencies
    to the latest versions.
    hhund committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    eda6767 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Configuration menu
    Copy the full SHA
    dc93f4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab3d581 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. reworked StructureDefinition snapshot generation and ValueSet expansion

    Snapshots are only generate for StructureDefinitions from the root
    validation package and its dependencies. ValueSet are only expanded if
    they are part of binding rules from these StructureDefinitions. The
    binding strength can be configured.
    hhund committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    18bea38 View commit details
    Browse the repository at this point in the history
  2. imports sorted

    hhund committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5b0ab5a View commit details
    Browse the repository at this point in the history
  3. modified/fixed log messages

    hhund committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    5f7d8b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0bb8975 View commit details
    Browse the repository at this point in the history
  5. snapshots now added to validator if errors occurred during generation

    change log level for errors during internal ValueSet expansion
    hhund committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    2eb3a38 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. fixed log message

    hhund committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    64da39d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. code cleanup/refactoring, NPE fix at ReadData when server not configured

    Added getServerBase Method to GeccoClient interface and implementing
    classes. Removed geccoServerBase field from ReadData service, since it
    may not be configured (when testing without GECCO FHIR Server or at the
    GTH), resulting in a NullPointerException.
    hhund committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    ca34abc View commit details
    Browse the repository at this point in the history
  2. fixed yml lint warnings, added docker-compose.override.yml to .gitignore

    The file codex-processes-ap1-docker-test-setup/docker-compose.override.yml
    has been added to .gitignore and can now be used to defined local
    overrides. See https://docs.docker.com/compose/extends on how to use
    override files.
    hhund committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    0793ab5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76c208a View commit details
    Browse the repository at this point in the history
  4. env variable to disable validation, error when profile not supported

    Added new environment variable to disable FHIR validation. Added new
    functionality to test if all resources are declaring at least on
    supported profile. A validation error is raised if no supported profile
    is defined. Profiles are supported if they are declared in the root
    validation package (currently de.gecco | 1.0.5) or are dependencies of
    the StructureDefinitions. Only profile with abstract = false and kind =
    resource are supported as claimed profiles by resources beeing
    validated.
    hhund committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    7bc60c1 View commit details
    Browse the repository at this point in the history