fix: upscale and division by zero issue #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use maxSize to downscale larger videos but smaller videos will also be upscaled to the maxSize in auto compression.
Also there is a division by zero issue when calculating min bitrate. It happens when getVideoBitrateWithFactor is divided by a number < 1. We need to first cast the result to float, make the division and then cast it back to int.
Changelog
fixed upscale and division by zero issue
Test Plan