Add github action for helm chart release and verify #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
chandankumar4
force-pushed
the
chart-release
branch
from
17115fc to
f24560b
Compare
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
chandankumar4
force-pushed
the
chart-release
branch
2 times, most recently
from
adc6670 to
e031465
Compare
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
chandankumar4
force-pushed
the
chart-release
branch
from
e031465 to
162fde9
Compare
whynowy
reviewed
May 24, 2024
.github/workflows/publish.yaml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Shall we use a tag to trigger the release? Otherwise every time there's a merge to main, it triggers a release?
There was a problem hiding this comment.
yaa, that can be also done btw via current way also it won't publish any release unless there is version chance in chart.yaml
There was a problem hiding this comment.
I don't think that we can use tag to release, as the github action(helm/chart-releaser-action) used inside workflow is itself creating release tag based on changed on main branch and here example also suggesting to use push on main branch
chandankumar4
force-pushed
the
chart-release
branch
7 times, most recently
from
cddc1e2 to
a43a101
Compare
chandankumar4
force-pushed
the
chart-release
branch
from
a43a101 to
4779d5d
Compare
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
chandankumar4
force-pushed
the
chart-release
branch
from
4779d5d to
909d94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6
Note: Have verified the helm chart release changes via github action with version 0.0.3