Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extra break point #25

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Benjamin-Etheredge
Copy link
Contributor

There was an extra breakpoint in role.yaml. This causes some linters and parsers to complain.

@vigith vigith requested a review from chandankumar4 November 26, 2024 18:32
@vigith
Copy link
Member

vigith commented Nov 26, 2024

@Benjamin-Etheredge please make DCO pass? linter failing is okay.

@vigith vigith requested a review from whynowy November 26, 2024 18:34
@Benjamin-Etheredge
Copy link
Contributor Author

Will do. Working on that now.

@Benjamin-Etheredge Benjamin-Etheredge force-pushed the main branch 2 times, most recently from d9607b5 to 92389dc Compare November 26, 2024 19:00
Signed-off-by: Ben <benjamin.etheredge@gmail.com>
@Benjamin-Etheredge
Copy link
Contributor Author

It took some git surgery and learning, but I think I fixed it.

@vigith vigith merged commit 58a68e2 into numaproj:main Nov 26, 2024
2 of 3 checks passed
@vigith vigith linked an issue Nov 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra breakpoint in role.yaml template
2 participants