Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement reduce stream sdk #91

Merged
merged 11 commits into from
Jan 23, 2024
Merged

feat: implement reduce stream sdk #91

merged 11 commits into from
Jan 23, 2024

Conversation

KeranYang
Copy link
Member

@KeranYang KeranYang commented Jan 15, 2024 •
edited
Loading

  • Define the user interface as two methods - processMessage and handleEndOfStream.
  • Continue using akka to handle concurrency. Introduce an OutputActor to make sure we are sending responses back to the gRPC output stream synchronously.

Testing: I developed a simple e2e test and it passed. KeranYang/numaflow#97

@KeranYang
copy reducer
593418a 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
an initial try
3164f91 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
add server unit tests
13a33b6 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
add an example
2174c73 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang KeranYang changed the title feat: implement reduce stream sdk feat(WIP): implement reduce stream sdk Jan 15, 2024
@KeranYang
add handleEndOfStream method
c2937a9 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
make it thread-safe
461610a 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang KeranYang changed the title feat(WIP): implement reduce stream sdk feat: implement reduce stream sdk Jan 18, 2024
@KeranYang KeranYang marked this pull request as ready for review January 18, 2024 01:19
@KeranYang KeranYang requested review from yhl25 and a team January 18, 2024 01:19
@KeranYang
a bit of clean up
49d2527 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
remove unnecessary synchronized keyword
4a6bc98 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
not expose output observer to the supervisor
c67de10 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
rename
cd07811 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
address comments
60c45fc 
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang KeranYang merged commit cb91f37 into numaproj:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy left review comments

@yhl25 yhl25 yhl25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeranYang @whynowy @yhl25