Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handshake for readFn and ackFn #88

Merged
merged 6 commits into from
Sep 20, 2024
Merged

fix: add handshake for readFn and ackFn #88

merged 6 commits into from
Sep 20, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Sep 17, 2024

No description provided.

@vigith vigith changed the title chore: add handshake for readFn chore: add handshake for readFn and ackFn Sep 20, 2024
@vigith vigith changed the title chore: add handshake for readFn and ackFn fix: add handshake for readFn and ackFn Sep 20, 2024
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 marked this pull request as ready for review September 20, 2024 15:15
@@ -42,9 +42,10 @@ pub(crate) mod simple_source {
let mut message_offsets = Vec::with_capacity(request.count);
for i in 0..request.count {
let offset = format!("{}-{}", event_time.timestamp_nanos_opt().unwrap(), i);
let payload = self.counter.fetch_add(1, Ordering::SeqCst).to_string();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not relaxed?

Signed-off-by: Vigith Maurice <vigith@gmail.com>
@vigith vigith enabled auto-merge (squash) September 20, 2024 15:37
@vigith vigith merged commit 7be70f4 into main Sep 20, 2024
2 checks passed
@vigith vigith deleted the handshake branch September 20, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants