fix(UI): Using limit instead of request to calculate usage percentage, fixes #1784 #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
…aproj#1895) Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com> Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: Derek Wang <whynowy@gmail.com> Co-authored-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: Vigith Maurice <vigith@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…oj#1904) Signed-off-by: Vigith Maurice <vigith@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com> Co-authored-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
…1918) Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com> Signed-off-by: Vigith Maurice <vigith@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: Vigith Maurice <vigith@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Matt Warner <matthew.d.warner@lmco.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: Vigith Maurice <vigith@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Keran Yang <yangkr920208@gmail.com> Signed-off-by: Yashash H L <yashashhl25@gmail.com> Co-authored-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com> Signed-off-by: Vigith Maurice <vigith@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Saniya Kalamkar <saniyakalamkar@saniyas-mbp-3.lan>
Signed-off-by: Saniya Kalamkar <saniya.kalamkar@gmail.com>
whynowy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 57.93% 58.18% +0.24%
==========================================
Files 402 402
Lines 28001 28061 +60
==========================================
+ Hits 16223 16326 +103
+ Misses 10847 10799 -48
- Partials 931 936 +5 ☔ View full report in Codecov by Sentry. |
|
perhaps rebase? |
|
Hey @SaniyaKalamkar, Yashash and I just made changes to our e2e tests and committed to the main. If you continue working on your branch, you might see some un-expected e2e testing failures. To fix them, please rebase. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1784. used cpu/memory limit instead of cpu/memory request to calculate usage percentages.