-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: merge to release v0.3 #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ab93
commented
Jan 5, 2023
•
edited
Loading
edited
- feat!: disentangle threshold selection from the main model
- feat!: convert AE variants to lightning modules
- fix!: move torch dependency away from main
- docs: update quick start, autoencoder and other docs
- example: update to add threshold vtx; remove poetry
- feat: add a lighter progress bar callback to make training faster and almost on par with native torch
* threshold estimators as separate models * remove threshold estimating from autoencoders * simplify mlflow model saving * mlflow now only supports saving per artifact * registry load function now returns a dataclass instead of dict * replace mlflow with mlflow-skinny to reduce unwanted dependencies Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
* fix: documentation for release 0.3 Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
* fix: move torch dependency away from main * fix: simple pipeline example * use pip as a dependency manager instead of poetry * add threshold vtx Signed-off-by: Avik Basu <avikbasu93@gmail.com>
* update & quick start * update autoencoder and other docs * add a lighter progress bar callback to make training faster and almost on par with native torch Signed-off-by: Avik Basu <avikbasu93@gmail.com> Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 95.79% 97.08% +1.29%
==========================================
Files 25 28 +3
Lines 975 961 -14
Branches 92 68 -24
==========================================
- Hits 934 933 -1
+ Misses 23 20 -3
+ Partials 18 8 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
vigith
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 have reviewed independent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.