Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: merge to release v0.3 #119

Merged
merged 16 commits into from
Jan 6, 2023
Merged

feat!: merge to release v0.3 #119

merged 16 commits into from
Jan 6, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Jan 5, 2023

  • feat!: disentangle threshold selection from the main model
  • feat!: convert AE variants to lightning modules
  • fix!: move torch dependency away from main
  • docs: update quick start, autoencoder and other docs
  • example: update to add threshold vtx; remove poetry
  • feat: add a lighter progress bar callback to make training faster and almost on par with native torch

ab93 and others added 13 commits November 9, 2022 19:52
* threshold estimators as separate models
* remove threshold estimating from autoencoders
* simplify mlflow model saving
* mlflow now only supports saving per artifact
* registry load function now returns a dataclass instead of dict
* replace mlflow with mlflow-skinny to reduce unwanted dependencies


Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
* fix: documentation for release 0.3

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
* fix: move torch dependency away from main
* fix: simple pipeline example
* use pip as a dependency manager instead of poetry
* add threshold vtx

Signed-off-by: Avik Basu <avikbasu93@gmail.com>
* update & quick start
* update autoencoder and other docs
* add a lighter progress bar callback to make training faster and almost on par with native torch

Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Co-authored-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
Signed-off-by: Avik Basu <avikbasu93@gmail.com>
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #119 (286695d) into main (4301147) will increase coverage by 1.29%.
The diff coverage is 97.51%.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   95.79%   97.08%   +1.29%     
==========================================
  Files          25       28       +3     
  Lines         975      961      -14     
  Branches       92       68      -24     
==========================================
- Hits          934      933       -1     
+ Misses         23       20       -3     
+ Partials       18        8      -10     
Impacted Files Coverage Δ
numalogic/registry/__init__.py 71.42% <75.00%> (+4.76%) ⬆️
numalogic/tools/__init__.py 80.00% <80.00%> (ø)
numalogic/tools/callbacks.py 89.47% <89.47%> (ø)
numalogic/models/threshold/_std.py 93.33% <93.33%> (ø)
numalogic/models/autoencoder/base.py 95.23% <95.23%> (+10.62%) ⬆️
numalogic/registry/mlflow_registry.py 90.65% <95.65%> (+0.65%) ⬆️
numalogic/_constants.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/__init__.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/trainer.py 100.00% <100.00%> (ø)
numalogic/models/autoencoder/variants/__init__.py 100.00% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 changed the title Merge main 0.3 feat: merge to release v0.3 Jan 5, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 changed the title feat: merge to release v0.3 feat!: merge to release v0.3 Jan 5, 2023
@ab93 ab93 self-assigned this Jan 5, 2023
@ab93 ab93 added this to the v0.3 milestone Jan 5, 2023
@ab93 ab93 marked this pull request as ready for review January 5, 2023 23:53
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 have reviewed independent PRs

@ab93 ab93 merged commit dca9a7a into main Jan 6, 2023
@ab93 ab93 deleted the merge-main-0.3 branch January 6, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants