Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add redis caching #179

Merged
merged 12 commits into from
May 10, 2023
Merged

fix: add redis caching #179

merged 12 commits into from
May 10, 2023

Conversation

s0nicboOm
Copy link
Contributor

@s0nicboOm s0nicboOm commented May 9, 2023

PR introduces:

  1. Adding caching for redis registry (includes code rearrangement)
  2. Fix mlflow test cases

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #179 (05f4463) into main (0f7e6e0) will decrease coverage by 0.08%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   96.80%   96.73%   -0.08%     
==========================================
  Files          36       36              
  Lines        1503     1530      +27     
  Branches      113      117       +4     
==========================================
+ Hits         1455     1480      +25     
  Misses         36       36              
- Partials       12       14       +2     
Impacted Files Coverage Δ
numalogic/registry/redis_registry.py 97.61% <95.45%> (-1.42%) ⬇️
numalogic/registry/artifact.py 91.66% <100.00%> (+0.36%) ⬆️
numalogic/registry/localcache.py 94.44% <100.00%> (+0.69%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review May 9, 2023 18:53
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93 ab93 added DO NOT MERGE area/registry Persistence/Storage changes labels May 10, 2023
s0nicboOm and others added 7 commits May 10, 2023 10:28
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm enabled auto-merge (squash) May 10, 2023 21:06
@s0nicboOm s0nicboOm disabled auto-merge May 10, 2023 21:06
@ab93 ab93 added the enhancement New feature or request label May 10, 2023
@ab93 ab93 enabled auto-merge (squash) May 10, 2023 21:27
@ab93 ab93 disabled auto-merge May 10, 2023 21:27
@ab93 ab93 merged commit 4a1effd into numaproj:main May 10, 2023
ab93 pushed a commit that referenced this pull request May 10, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93 pushed a commit that referenced this pull request May 11, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93 ab93 mentioned this pull request May 11, 2023
ab93 pushed a commit that referenced this pull request May 11, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Persistence/Storage changes DO NOT MERGE enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants