-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add redis caching #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 96.80% 96.73% -0.08%
==========================================
Files 36 36
Lines 1503 1530 +27
Branches 113 117 +4
==========================================
+ Hits 1455 1480 +25
Misses 36 36
- Partials 12 14 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
nkoppisetty
requested changes
May 9, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93
reviewed
May 9, 2023
nkoppisetty
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93
approved these changes
May 9, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93
pushed a commit
that referenced
this pull request
May 10, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93
pushed a commit
that referenced
this pull request
May 11, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Merged
ab93
pushed a commit
that referenced
this pull request
May 11, 2023
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR introduces: