fix: optional dependency imports #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 96.96% 96.80% -0.16%
==========================================
Files 36 36
Lines 1482 1503 +21
Branches 111 113 +2
==========================================
+ Hits 1437 1455 +18
- Misses 33 36 +3
Partials 12 12
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
s0nicboOm
approved these changes
May 10, 2023
nkoppisetty
approved these changes
May 10, 2023
ab93
added a commit
that referenced
this pull request
May 10, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
ab93
added a commit
that referenced
this pull request
May 11, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Merged
ab93
added a commit
that referenced
this pull request
May 11, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when a config-based import fails if one of the optional dependencies is not installed.