Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Auto detect instance type while mlflow model save #190

Merged
merged 4 commits into from
May 11, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented May 11, 2023

Helps for a better config-driven registry instance creation.

  • Avoid specifying mlflow instance type in the constructor
  • Detect the correct handler during save
  • Specify artifact type during load
  • Update docs

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 added the area/registry Persistence/Storage changes label May 11, 2023
@ab93 ab93 added this to the v0.4 milestone May 11, 2023
@ab93 ab93 self-assigned this May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #190 (06f96de) into main (4a1effd) will decrease coverage by 0.57%.
The diff coverage is 85.18%.

❗ Current head 06f96de differs from pull request most recent head cdae6b9. Consider uploading reports for the commit cdae6b9 to get more accurate results

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   97.12%   96.56%   -0.57%     
==========================================
  Files          36       36              
  Lines        1530     1541      +11     
  Branches      117      119       +2     
==========================================
+ Hits         1486     1488       +2     
- Misses         32       38       +6     
- Partials       12       15       +3     
Impacted Files Coverage Δ
numalogic/registry/mlflow_registry.py 83.76% <84.00%> (-2.95%) ⬇️
numalogic/tools/types.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review May 11, 2023 00:25
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 requested a review from mboussarov May 11, 2023 00:58
Copy link
Contributor

@s0nicboOm s0nicboOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

numalogic/registry/mlflow_registry.py Show resolved Hide resolved
tests/registry/test_mlflow_registry.py Outdated Show resolved Hide resolved
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 merged commit efa1df7 into main May 11, 2023
@ab93 ab93 deleted the mlflow-instance-type branch May 11, 2023 17:41
ab93 added a commit that referenced this pull request May 11, 2023
Helps for a better config-driven registry instance creation.

- Avoid specifying mlflow instance type in the constructor
- Detect the correct handler during save
- Specify artifact type during load
- Update docs

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 mentioned this pull request May 11, 2023
ab93 added a commit that referenced this pull request May 11, 2023
Helps for a better config-driven registry instance creation.

- Avoid specifying mlflow instance type in the constructor
- Detect the correct handler during save
- Specify artifact type during load
- Update docs

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Persistence/Storage changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants