-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Auto detect instance type while mlflow model save #190
Conversation
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 97.12% 96.56% -0.57%
==========================================
Files 36 36
Lines 1530 1541 +11
Branches 117 119 +2
==========================================
+ Hits 1486 1488 +2
- Misses 32 38 +6
- Partials 12 15 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Helps for a better config-driven registry instance creation. - Avoid specifying mlflow instance type in the constructor - Detect the correct handler during save - Specify artifact type during load - Update docs Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Helps for a better config-driven registry instance creation. - Avoid specifying mlflow instance type in the constructor - Detect the correct handler during save - Specify artifact type during load - Update docs Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
Helps for a better config-driven registry instance creation.