-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versioneer to 3.12 #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are good but GHA CI is not happy!? Why are jobs cancelled?
using `versioneer install --vendor` in a 3.12 env
8309f12
to
7b80e48
Compare
Not sure yet, seems like one failed job causes the others to fail too, have to triage some more. |
This reverts commit 7b80e48.
@sklam seems like the CI system isn't quite ready to be bumped to 3.12 just yet, I reverted the bump and seems like all tests are passing now. The GHA works like this: we build a package on 3.10 and then test on 3.8 -- 3.11 . When adding 3.12 to the mix we end up with:
to setup the test env. But then attempting to install the build artifact in this environment yields:
Which is odd as the My suggestion here is to divide and conquer. Since this PR only affects the vendored versioneer files -- which seem to pass on the current CI config -- and these files are auto-generated -- so would suggest to get this merged up and refactor and fixup support for 3.12 in a subsequent PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should divide and conqueur.
using
versioneer install --vendor
in a 3.12 env