Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in SDRClassifier serialization/deserialization #3172

Closed
natoromano opened this issue Jun 20, 2016 · 0 comments
Closed

Bug in SDRClassifier serialization/deserialization #3172

natoromano opened this issue Jun 20, 2016 · 0 comments

Comments

@natoromano
Copy link
Contributor

natoromano commented Jun 20, 2016

Updating integration tests with the SDRClassifier showed an error, likely in SDRClassifierRegion. The test opf/opf_checkpoint_test.NonTemporalMultiStep fails when loading a pre-trained model and comparing with one dynamically trained:

AssertionError: 8 != 1 : Mismatch in predicted values: row 278 of a+b has 8 predictions: 
E       ([(0.5269586552579024, 412.0), (0.03142243291403317, 373.26925807999993), (0.02579078528165298, 353.3712486399999), (0.012091269746045623, 379.3483099999999), (0.010465308012194129, 391.236), (0.007283412279594604, 802.0), (0.007121068269599478, 1103.0), (0.007120728734406587, 851.0)]) and row 28 of b has 1 predictions:
E       ([(1.0, 412.0)])

Fix will be part of PR #3168, which updates examples and tests with the SDR classifier instead of the CLA classifier.'

Update: there are actually a few bugs in object conversions when serializing a SDR classifier using the new method. PR #3168 will address those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant