-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --debug option to setup.py #1907
Conversation
@rhyolight ok when 🍏 ? |
commonCompileFlags.append("-flto-report") | ||
commonCompileFlags.append("-fuse-ld=gold") | ||
commonCompileFlags.append("-flto") | ||
commonLinkFlags.append("-flto") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this simpler by updating getCommandLineOption()
to handle None
. Then you could just make it:
if getCommandLineOption("debug", cmdOptions):
...
else if getCommandLineOption("optimizations-native", cmdOptions):
...
else if getCommandLineOption("optimizations-lto", cmdOptions):
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, I meant:
if getCommandLineOption("debug", cmdOptions):
...
else:
if getCommandLineOption("optimizations-native", cmdOptions):
...
else if getCommandLineOption("optimizations-lto", cmdOptions):
...
This just prevents all the null-checks and makes it easier to read.
Thanks @rhyolight looks better now! |
add --debug option to setup.py
add --debug option to setup.py
Fixes: #1906