-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove $NUPIC dependency #1968
Remove $NUPIC dependency #1968
Conversation
had an issue with the NUPIC variable, heared you were about to remove them anyways, so I just did it :) Hope this helps :)
Thanks, @passiweinberger. I will try to test this out Monday. |
Although this fixes tests, not sure it fixes the general swarming problem. |
Yes. True, I'll get my hand on it 2day. Sorry don't merge yet -------- Original message -------- From: Matthew Taylor notifications@github.com Date:03/30/2015 03:48 (GMT+01:00) To: numenta/nupic nupic@noreply.github.com Cc: Pascal Weinberger passiweinberger@gmail.com Subject: Re: [nupic] Remove $NUPIC dependency (#1968) — |
But wanted to make sure this way to fix it is acceptable :) |
I had a go at removing all $NUPIC dependencies, too. Saw too late, that @passiweinberger was working on it. It's surely a more controversial approach and I'm not sure if that's in line with Python best practices, but please have a look: #1970 |
Now it removes the NUPIC path completely as suggested by @david-ragazzi in #1970 if we decide to do it :) |
HI @passiweinberger , I think it's better we keep a single PR for this issue. :-/ So how about push this change and adapt to my suggestion (https://github.com/numenta/nupic/pull/1970/files#r27405407) into @pehlert branch. This way we centralize efforts.. :-) |
(Y) |
Seems to me like #1970 should be merged first, and then this PR should be updated to use |
blocked by #1970 |
had an issue with the NUPIC variable, heared you were about to remove them anyways, so I just did it :) Hope this helps :)
fixes #1947