Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $NUPIC dependency #1968

Closed
wants to merge 20 commits into from
Closed

Remove $NUPIC dependency #1968

wants to merge 20 commits into from

Conversation

passiweinberger
Copy link
Member

had an issue with the NUPIC variable, heared you were about to remove them anyways, so I just did it :) Hope this helps :)

fixes #1947

had an issue with the NUPIC variable, heared you were about to remove them anyways, so I just did it :) Hope this helps :)
@rhyolight
Copy link
Member

Thanks, @passiweinberger. I will try to test this out Monday.

@rhyolight
Copy link
Member

Although this fixes tests, not sure it fixes the general swarming problem.

@passiweinberger
Copy link
Member Author

Yes. True, I'll get my hand on it 2day. Sorry don't merge yet

-------- Original message --------
From: Matthew Taylor notifications@github.com
Date:03/30/2015 03:48 (GMT+01:00)
To: numenta/nupic nupic@noreply.github.com
Cc: Pascal Weinberger passiweinberger@gmail.com
Subject: Re: [nupic] Remove $NUPIC dependency (#1968)
Although this fixes tests, not sure it fixes the general swarming problem.


Reply to this email directly or view it on GitHub.

@passiweinberger
Copy link
Member Author

But wanted to make sure this way to fix it is acceptable :)

@pehlert
Copy link
Contributor

pehlert commented Mar 30, 2015

I had a go at removing all $NUPIC dependencies, too. Saw too late, that @passiweinberger was working on it. It's surely a more controversial approach and I'm not sure if that's in line with Python best practices, but please have a look: #1970

@passiweinberger
Copy link
Member Author

@pehlert s fix #1970 works. Close this one, no need for dublicates :D

@passiweinberger passiweinberger deleted the patch-1 branch March 30, 2015 12:08
@passiweinberger passiweinberger restored the patch-1 branch March 30, 2015 16:15
@passiweinberger
Copy link
Member Author

Now it removes the NUPIC path completely as suggested by @david-ragazzi in #1970 if we decide to do it :)

@david-ragazzi
Copy link
Contributor

HI @passiweinberger , I think it's better we keep a single PR for this issue. :-/ So how about push this change and adapt to my suggestion (https://github.com/numenta/nupic/pull/1970/files#r27405407) into @pehlert branch. This way we centralize efforts.. :-)

@passiweinberger
Copy link
Member Author

(Y)
How do I do this btw. ? :P

@rhyolight
Copy link
Member

Seems to me like #1970 should be merged first, and then this PR should be updated to use NUPIC_ROOT?

@rhyolight
Copy link
Member

blocked by #1970

@passiweinberger
Copy link
Member Author

#2205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swarming returns JSON error when NUPIC environment variable is unset
4 participants