Snake case module names PART 1 #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed: src/nupic/frameworks/opf/htmpredictionmodelcallbacks.py
-> src/nupic/frameworks/opf/htm_prediction_model_callbacks.py
renamed:
src/nupic/frameworks/opf/htmpredictionmodel_classifier_helper.py ->
src/nupic/frameworks/opf/htm_prediction_model_classifier_helper.py
renamed: src/nupic/frameworks/opf/modelcallbacks.py ->
src/nupic/frameworks/opf/model_callbacks.py
renamed: src/nupic/frameworks/opf/modelfactory.py ->
src/nupic/frameworks/opf/model_factory.py
renamed: src/nupic/frameworks/opf/opfbasicenvironment.py ->
src/nupic/frameworks/opf/opf_basic_environment.py
renamed: src/nupic/frameworks/opf/opfenvironment.py ->
src/nupic/frameworks/opf/opf_environment.py
renamed: src/nupic/frameworks/opf/opfhelpers.py ->
src/nupic/frameworks/opf/opf_helpers.py
renamed: src/nupic/frameworks/opf/opfutils.py -> src/nupic/frameworks/opf/opf_utils.py
|
Ignore "Fixes Issue" validation failure. |
|
@scottpurdy can you review this? |
scottpurdy
reviewed
Apr 24, 2017
There was a problem hiding this comment.
Looks fine to me. I don't think we should have a complete example not using the network api. It's fine if we want to show usage of a given algorithm component individually, but for the complete example we should just show the recommended way with the network api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #3546
Part one of several PRs to rename python files and module names. Breaking into parts to make it easier to merge.
Includes the following renamings: