NUP-2397: rename TP* to TM* #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 17, 2017 13:32
* TPShimMixin to TMShimMixin * TPShim to TMShim * MonitoredTPShim to MonitoredTMShim * FastTPShim to FastTMShim * TPCPPShim to TMCPPShim
|
@marionleborgne Will review today |
rhyolight
requested changes
Apr 24, 2017
examples/NuPIC Walkthrough.ipynb
Outdated
| @@ -674,7 +674,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "# Step 1: create Temporal Pooler instance with appropriate parameters\n", | |||
| "tp = TP(numberOfCols=50, cellsPerColumn=2,\n", | |||
| "tm = TP(numberOfCols=50, cellsPerColumn=2,\n", | |||
There was a problem hiding this comment.
Is this constructor call still valid?
There was a problem hiding this comment.
I think so (with BacktrackignTM). I fixed the notebook, and everything executes properly now.
examples/tm/tm_constant_test.py
Outdated
| seed=SEED, verbosity=VERBOSITY, | ||
| checkSynapseConsistency=True, | ||
| pamLength=1000) | ||
| cppTp = BacktrackingTMCPP(numberOfCols=numCols, |
examples/tm/tm_constant_test.py
Outdated
| globalDecay=globalDecay, burnIn=1, | ||
| seed=SEED, verbosity=VERBOSITY, | ||
| pamLength=1000) | ||
| pyTp = BacktrackingTM(numberOfCols=numCols, |
src/nupic/math/roc_utils.py
Outdated
| @@ -229,7 +229,7 @@ def _test(): | |||
| 1 0.3 0 0 0 1 1 | |||
| 1 0.45 0 1 1 1 1 | |||
|
|
|||
| TruePos(TP) 1 2 2 3 3 | |||
| TruePos(TM) 1 2 2 3 3 | |||
There was a problem hiding this comment.
This TM should not be replaced because it means TruePos.
There was a problem hiding this comment.
Thanks! I missed that
src/nupic/math/roc_utils.py
Outdated
| @@ -238,7 +238,7 @@ def _test(): | |||
| The ROC curve is a plot of FPR on the x-axis and TPR on the y-axis. Basically, | |||
| one can pick any operating point along this curve to run, the operating point | |||
| determined by which threshold you want to use. By changing the threshold, you | |||
| tradeoff TP's for FPs. | |||
| tradeoff TM's for FPs. | |||
|
@rhyolight thanks for the feedback. I addressed your comments. |
|
@marionleborgne Thanks, you'll need to merge. |
added 3 commits
April 26, 2017 11:22
…97-rename-tp-to-tm # Resolved conflicts with: # docs/examples/opf/model_params.py # examples/opf/experiments/anomaly/spatial/10field_many_balanced/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/spatial/10field_many_balanced/description.py # examples/opf/experiments/anomaly/temporal/noisy_saw/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/temporal/noisy_saw/description.py # examples/opf/experiments/anomaly/temporal/saw_200_category/UNDER_DEVELOPMENT # examples/opf/experiments/anomaly/temporal/saw_200_category/description.py # tests/unit/nupic/frameworks/opf/htmpredictionmodel_classifier_helper_test.py
|
@rhyolight I merged. It's ready for you to review again. |
rhyolight
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3556
Name changes:
TPRegiontoTMRegionTPtoBacktrackingTMTP10X*toBacktrackingTMCPPTPShim*toTMShim*TP / temporal poolingtoTM / temporal memory.