Removes inputRef / bookmark params from appendRecord #3597
Conversation
…tream-appendrecord-bookmark
…tream-appendrecord-bookmark
|
@scottpurdy I wanted to get a quick review of the removal of I don't see where this parameter is used anywhere in our code or tests. The rest of the changes in this PR are just docstring updates. |
| @@ -303,7 +304,7 @@ def getNextRecordIdx(self): | |||
|
|
|||
|
|
|||
| @abstractmethod | |||
| def appendRecord(self, record, inputRef=None): | |||
| def appendRecord(self, record): | |||
There was a problem hiding this comment.
Removed inputRef here in the abstract method.
| @@ -313,7 +314,7 @@ def appendRecord(self, record, inputRef=None): | |||
|
|
|||
|
|
|||
| @abstractmethod | |||
| def appendRecords(self, records, inputRef=None, progressCB=None): | |||
| def appendRecords(self, records, progressCB=None): | |||
There was a problem hiding this comment.
Removed inputRef here in the abstract method.
| for record in records: | ||
| self.appendRecord(record, None) | ||
| self.appendRecord(record) |
There was a problem hiding this comment.
No need to send None anymore.
| @@ -418,22 +418,17 @@ def appendRecord(self, record, inputBookmark=None): | |||
| self._recordCount += 1 | |||
|
|
|||
|
|
|||
| def appendRecords(self, records, inputRef=None, progressCB=None): | |||
| def appendRecords(self, records, progressCB=None): | |||
There was a problem hiding this comment.
Removed inputRef here in the implementation method.
| @@ -387,7 +387,7 @@ def getNextRecord(self, useCache=True): | |||
| return record | |||
|
|
|||
|
|
|||
| def appendRecord(self, record, inputBookmark=None): | |||
| def appendRecord(self, record): | |||
There was a problem hiding this comment.
Removed inputRef here in the implementation method.
src/nupic/data/stream_reader.py
Outdated
| """ | ||
| return self._aggMonthsAndSeconds | ||
|
|
||
|
|
||
| def appendRecord(self, record, inputRef=None): | ||
| """Saves the record in the underlying storage.""" | ||
| def appendRecord(self, record): |
There was a problem hiding this comment.
Removed inputRef here in the implementation method.
src/nupic/data/stream_reader.py
Outdated
| raise RuntimeError("Not implemented in StreamReader") | ||
|
|
||
|
|
||
| def appendRecords(self, records, inputRef=None, progressCB=None): | ||
| """Saves multiple records in the underlying storage.""" | ||
| def appendRecords(self, records, progressCB=None): |
There was a problem hiding this comment.
Removed inputRef here in the implementation method.
…tream-appendrecord-bookmark
|
AppVeyor is stalled, and I'm not waiting for it. |
Fixes #3592
builds upon #3593