Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved opf_helpers module to helpers #3610

Merged
merged 2 commits into from
May 11, 2017
Merged

Moved opf_helpers module to helpers #3610

merged 2 commits into from
May 11, 2017

Conversation

rhyolight
Copy link
Member

fixes #3609

@rhyolight rhyolight requested a review from scottpurdy May 10, 2017 22:33
@rhyolight
Copy link
Member Author

@scottpurdy I'm not sure this is an idea we should follow through on. I honestly don't care either way. But here it is.

scottpurdy
scottpurdy approved these changes May 11, 2017
View reviewed changes
Copy link
Contributor

@scottpurdy scottpurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference. This change matches what I would typically recommend (don't be redundant) but referencing "helpers" in the code isn't very descriptive compared with something like "opf_helpers.loadExperiment..."

So up to you :)

@rhyolight
Copy link
Member Author

Good point. Users can always from nupic.frameworks.opf import helpers as opf_helpers.

@rhyolight rhyolight merged commit c7149e2 into numenta:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottpurdy scottpurdy scottpurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move opf_helpers.py to helpers.py
2 participants
@rhyolight @scottpurdy