NUP-2354 Implement serialization for TMRegion #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 31, 2017 15:02
…apnp buffer-passing fix needed by this commit. NUP-2354 Added capnp serialization/deserialization support in TMRegion and TMShimMixin classes. NUP-2354 Fixed parameter specs of boolean TMRegion parameters to use "Bool" type instead of "UInt32".
…bindings v0.6.2 to work around version
conflict "pkg_resources.VersionConflict: (pytest-cov 1.6 (/usr/local/lib/python2.7/dist-packages), Requirement.parse('pytest-cov==2.5.0'))"
…n nupic.bindings v0.6.2 to work around version" This reverts commit 611363d. We should have a separate PR to deal with all the python package incompatibilities brought about by dependency upgrades in nupic.core.
|
Please review. cc @scottpurdy |
scottpurdy
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2183
NOTE: there are package incompatibilities brought on by python package version upgrades in nupic.bindings 0.6.2. A separate PR to deal with those incompatibilities should be created, merged, and then picked up by this PR. Apparently, @mrcslws is working on nupic.core and nupic PRs that reinstates package compatibility.
NUP-2354 Upgrade nupic.bindings dependency to v0.6.2 to pick up the capnp buffer-passing fix needed by this commit.
NUP-2354 Added capnp serialization/deserialization support in TMRegion and TMShimMixin classes.
NUP-2354 Fixed parameter specs of boolean TMRegion parameters to use "Bool" type instead of "UInt32".
NOTE: The alias "monitored_tm_py" and corresponding nupic class backtracking_tm_shim.MonitoredTMShim don't seem to be used by anything. Per offline discussion with Scott via HipChat, we're not going to add capnp support to MonitoredTMShim