-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Serializable to all classes with a capnp write function #3710
Conversation
The MovingAverage class does not implement the abstract method getSchema |
@lscheinkman Even after that change, I still get the same error on MovingAverage. |
remove
|
Thanks @lscheinkman that was it. |
src/nupic/utils.py
Outdated
|
||
@classmethod | ||
def getSchema(cls): | ||
raise NotImplementedError() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should return MovingAverageProto
from this import
from nupic.movingaverage_capnp import MovingAverageProto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment on https://github.com/numenta/nupic/pull/3710/files#r122292812
@lscheinkman ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
investigating test failure 🤷♂️ |
You need to add capnp conditionals for Windows. Something like this:
|
@lscheinkman thanks for the help |
There is a problem with this PR, tests will fail with this error, but I'm not sure why: