numenta/nupic.core#1380: Fix SP tests with correct dtype values #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of numenta/nupic.core-legacy#1380 fix, the
swiginterface now validates thenumpy.arraytype making sure it matches the C++ implementation (nupic::UInt). It will now throw an exception when thecomputemethod is called with the wrong data type.This PR adds a new test checking if cpp SP swig interface is validating the input values and fixes other SP tests affected by this change.
This PR depends on numenta/nupic.core-legacy#1385 do not merge until numenta/nupic.core-legacy#1385 is merged