Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devdoc build using the scipy-sphinx-theme-v2 #2

Closed
wants to merge 4 commits into from

Conversation

Shekharrajak
Copy link
Member

@rgommers
Copy link
Member

There's a ton of SVG images for math expressions in this PR. I think you still have pngmath or imgmath in your config somewhere, it should be changed to using mathjax so we get rendered math in the browser rather than static images.

I don't think the rest of this PR is reviewable before that is fixed, it has 3000+ changed files.

@Shekharrajak
Copy link
Member Author

Shekharrajak commented Nov 26, 2019

I have removed plugins sphinx.ext.imgmath which were generating images in _image/math folder. I am using js directly here instead of sphinx plugin so they are not needed.

I have removed the build related hidden files as well.

@rgommers
Copy link
Member

Ah the link above it moved, it's loaded directly in the html: scipy/scipy-sphinx-theme-v2@2f8cb2e

I suspect that this is the more correct way of doing it: https://github.com/scipy/scipy/blob/master/doc/source/conf.py#L44. I think mathjax config belongs in the config of the project using the theme, rather than hardcoded in the theme. The old Sphinx theme doesn't have anything.

This PR also still has thousands of .doctree files, do those need to be there?

@Shekharrajak
Copy link
Member Author

Thanks @rgommers! I will try with plugin once again (last time I find some issue with generated the latex version for the equations, so I tried to add the JS in script itself).

@Shekharrajak
Copy link
Member Author

Ah the link above it moved, it's loaded directly in the html: scipy/scipy-sphinx-theme-v2@2f8cb2e

I suspect that this is the more correct way of doing it: https://github.com/scipy/scipy/blob/master/doc/source/conf.py#L44. I think mathjax config belongs in the config of the project using the theme, rather than hardcoded in the theme. The old Sphinx theme doesn't have anything.

This PR also still has thousands of .doctree files, do those need to be there?

Fixed it here : scipy/scipy-sphinx-theme-v2#73

@mattip
Copy link
Member

mattip commented Oct 20, 2020

Closing. HEAD had moved to the pydata_sphinx_theme from Pandas.

@mattip mattip closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants