-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 2.0 documentation and make it the stable version #24
Conversation
cc @charris |
Beyond adding the 2.0 files, I also
|
The version warning should be provided by the pydata sphinx theme now - so we should add
to conf.py (see https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/announcements.html#version-warning-banners - this page will actually show the functionality at the top) |
Can we do that in a follow on? I think this should be merged soon Edit: make the responseinto a question |
The stable docs will have to be rebuilt for that. If that's not an issue I'm happy to do It in a follow up 👍 |
I don't think rebuilding is an issue. More of a problem is getting the warning into the 1.26 and earlier docs. |
Lets just get this in. |
I just submitted a PR to fix the version switcher as well: #25 I'll send another to turn on the version warning banner for the newer versions of the docs. |
@melissawm Is there any reason not to merge this? If not, hit the merge button. |
Please merge, we can fix the warning banner later. Just make sure to also merge the version switcher json update over at #25 |
Melissa, I want you to merge. You will feel better after :) EDIT: Do you have commit rights? |
I do, thanks @charris - let's do it, if I break it, it won't be the first time 😄 |
I followed the instructions in the Makefile, except for the force push.