This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Added hint for ndarray.__new__ #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a bigger issue about defining buffer types (python/typing#593), but this seems like a good start. Thanks @bedder ! |
|
Thanks to everyone working on this project - it's a really useful addition to numpy! At my work we've ended up creating a public fork of this project, and have slowly been adding type hints for more of the numpy library. If it would be useful to yourselves (and not too spammy), we'd be happy to raise more PRs for the additions we've been using internally. |
|
Yes, we would be very happy to review pull requests!
…On Mon, Jul 8, 2019 at 2:25 AM Matthew Bedder ***@***.***> wrote:
Thanks to everyone working on this project - it's a really useful addition
to numpy!
At my work we've ended up creating a public fork of this project
<https://github.com/Prowler-io/numpy-stubs>, and have slowly been adding
type hints for more of the numpy library. If it would be useful to
yourselves (and not too spammy), we'd be happy to raise more PRs for the
additions we've been using internally.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#29?email_source=notifications&email_token=AAJJFVVNZZQ3N64UIAPPR7LP6MBW7A5CNFSM4HVVJA32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMQJCQ#issuecomment-509150346>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJJFVSR3S5NEX7BP4BSMADP6MBW7ANCNFSM4HVVJA3Q>
.
|
|
Feel free to ping me directly for reviews -- this repo has been a little
quiet recently (and GitHub's notifications UI for maintainers is a bit of a
mess) so I have been missing some activity here.
…On Mon, Jul 8, 2019 at 8:34 AM Stephan Hoyer ***@***.***> wrote:
Yes, we would be very happy to review pull requests!
On Mon, Jul 8, 2019 at 2:25 AM Matthew Bedder ***@***.***>
wrote:
> Thanks to everyone working on this project - it's a really useful
> addition to numpy!
>
> At my work we've ended up creating a public fork of this project
> <https://github.com/Prowler-io/numpy-stubs>, and have slowly been adding
> type hints for more of the numpy library. If it would be useful to
> yourselves (and not too spammy), we'd be happy to raise more PRs for the
> additions we've been using internally.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#29?email_source=notifications&email_token=AAJJFVVNZZQ3N64UIAPPR7LP6MBW7A5CNFSM4HVVJA32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMQJCQ#issuecomment-509150346>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAJJFVSR3S5NEX7BP4BSMADP6MBW7ANCNFSM4HVVJA3Q>
> .
>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy.ndarray.__new__previously did not have any type definitions, meaning that code that directly instantiatesnp.ndarrayinstances would be flagged by mypy as having unexpected arguments.I think this should fix the issue - at the very least this change removes what I consider to be invalid warnings on my codebase - although I'm unsure about whether the type for the buffer is correct.