-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/code demo #71
Conversation
@joelachance This is great! Should we consider a more minimalistic environment with only NumPy installed, and perhaps initialize the terminal with numpy already imported as np? |
I like this as well! It's quite responsive, much faster than I'm used to with Binder. I guess it's a function of the set of requirements.
Is this for loading speed, or for saving Binder resources, or ... ? |
It probably won't affect the loading speed too much; more so we have control over the environment we operate in (numpy version, etc.). If we want to increase response time, we do have the option of hosting (or sponsoring) a MyBinder instance that serves the NumPy image exclusively (most of the start-up time on the MyBinder time is spent moving images to execution nodes, if I understand correctly). There are further optimizations on the table, such as holding a cache of ready kernels and dishing them out as needed, but that is clearly out of scope for this project. |
Adding just And perhaps we can put the |
@scopatz this is the PR with ThebeLab that we talked about. @joelachance, @scopatz is working on something similar, more general / not Jupyter based (he can explain better). He may be interested to chat/collaborate. |
Thanks @rgommers! @joelachance - can we maybe jump on a call next week sometime? Feel free to email me at scopatz(AT)quansight.com |
What we currently have in this PR is the default ThebeLab/Binder image. We can create our own if we'd like, but we will have to host it somewhere. The default image is already very minimal, but as it does take a brief moment to initialize, a smaller image might improve loading time (probably not a huge priority). A couple of enhancements I think would be nice are as follows:
There's one or two more, but I can't remember right now :) I'm on the fence about including |
@scopatz, I will email you! |
@@ -21,5 +21,7 @@ | |||
<!-- Google Fonts - Ubuntu --> | |||
<link href="https://fonts.googleapis.com/css?family=Ubuntu&display=swap" rel="stylesheet"> | |||
<link href="https://fonts.googleapis.com/css?family=Rubik&display=swap" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using Lato font now then can we remove Rubik font link ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can.
I've been playing around with fonts for the main hero title. I'm not sure Ubuntu is the best choice here, although I do think it looks quite nice for body text.
I'll write more soon in #48.
This is in good shape so I'm merging it to not have to migrate it to |
Thanks @joelachance and all reviewers, this is really nice! |
@joelachance @rgommers To follow up on our last meeting discussion I'm submitting the screenshots of the homepage shell. Runing on MacOS. It’s the same scenario with Safari and Firefox. I'm unable to get past the third screenshot. It was not an issue while I was in the US. Let me know if I should open a separate issue for this. |
@InessaPawson The third screenshot is the shell itself-- I had restyled it, but you're the second person to note some confusion about the new styles, so I'm planning on updating this to look more like it did before. If you click at the end of the |
A-ha! I guess, my confusion is exacerbated by the fact that I remember the previous version.:) Perhaps, we could offer a prompt in a darker shade of grey, e.g. “Enter your code here…” |
Resolves #66