-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Add Python 3.11 wheels to aarch64 build #22127
Conversation
Apparently Python 3.11 is not available. I built the aarch64 wheel with multibuild, but it would be nice if we could make the build here more timely. Deadsnakes, perhaps? |
There is CIBW_PRERELEASE_PYTHONS. The PR pypa/cibuildwheel#1226 to allow specifying 3.11 without that flag was merged 3 days ago. |
Digging a little more. cibuildwheel 2.9.0 enables building 3.11 wheels without |
And now that I actually read the build log and this PR, I see
Is that download choice coming from cibuildwheel or from travis? |
Don't know, but I suspect cibuildwheel isn't involved in the travis builds. For multibuild I did the old Python 3.10 for Ubuntu, Python 3.11 for manylinux2014 trick to make the wheels. I think we need something similar here. Note that travis claims to have one of the betas, but I don't know how to specify it. I'm thinking that for the wheel builds we should use the Ubuntu default Python to run the downloaded docker images so we don't need to worry about Ubuntu keeping current. |
I would like some explanation of how this all works here. I could read the code, but that is work :) |
arch: arm64 | ||
virt: vm | ||
env: | ||
- CIBW_BUILD: cp311-manylinux_aarch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CIBW_BUILD
directive determines which build is performed. You should be able to use whatever python you want in the - python:
directive (line 94, 81, 68) since the build actually occurs inside a manylinux_aarch64 docker image, i.e. manylinux 2014.
Hmm. The default Python for focal is 3.8. Let's see if it works to use 3.8 for all the wheel builds. |
Co-authored-by: Matti Picus <matti.picus@gmail.com>
94c29f5
to
fe3893f
Compare
Looks like specifying Python 3.8 worked and, judging by the names, the correct wheels were built. |
Thanks @charris |
@mattip Any idea what Python is used for the tests? |
The tests are run in the same docker image. For instance the 3.9 tests are run with python3.9 and the numpy 3.9 newly-created wheel. |
No description provided.