feat/nixos module #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only thing the go code does anymore is generate the hardware report. We will replace the config generation with a NixOS module. Signed-off-by: Brian McGee <brian@bmcgee.ie>
- snake_case for json output - key hardware lists by hardware class - canonically sort hardware lists e.g. stable report output Signed-off-by: Brian McGee <brian@bmcgee.ie>
Signed-off-by: Brian McGee <brian@bmcgee.ie>
Lassulus
reviewed
Jul 10, 2024
Mic92
reviewed
Jul 11, 2024
phaer
reviewed
Jul 15, 2024
I think thats good to update now? flake.lock still points to your local blueprint checkout. |
brianmcgee
force-pushed
the
feat/nixos-module
branch
2 times, most recently
from
3af5f06
to
ebbc6f3
Compare
A first pass at an architecture for generating NixOS configuration based on the nixos-facter json output. Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/nixos-module
branch
from
ebbc6f3
to
8759f5d
Compare
Breaking change in how nixos configurations are specified. Signed-off-by: Brian McGee <brian@bmcgee.ie>
Lassulus
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first attempt at a pattern for building up NixOS modules from the json report produced by
nixos-facter.TODO
nix-unitwhilst also integrating withnumtide/blueprintnix-unittests as part ofnix flake checkblueprintflake input once feat: fallback to default.nix in host config blueprint#25 is merged