-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old deprecation warning for ruff #211
Comments
I'm not able to reproduce locally. Can you share the code? |
This comment was marked as outdated.
This comment was marked as outdated.
So I made a repo https://github.com/phanirithvij/nix-eval-bugreport, just do Also to reproduce it I had to |
So my guess is it is working as it is supposed to? So this is a non-issue but since I keep modifying my flake regularly I keep seeing this frequently. |
Thanks. This is surprising to me, too, so I will use your repo to investigate. I would expect the warning to only show up when the enable option is being used. I also noticed that |
My guess is it is same as NixOS/nixpkgs#306276 Edit: nvm I don't know what I'm talking about. |
When using `lib.mkRenamedOptionModule`, the trace warning is emitted whenever the option is accessed. Because we iterate and check the .enable option of all the programs, the renamed option gets accessed all the time. So we check if the option is "visible" before checking in, which `lib.mkRenamedOptionModule` sets to false. Fixes #211
When using `lib.mkRenamedOptionModule`, the trace warning is emitted whenever the option is accessed. Because we iterate and check the .enable option of all the programs, the renamed option gets accessed all the time. So we check if the option is "visible" before checking in, which `lib.mkRenamedOptionModule` sets to false. Fixes #211
👍 thanks, found the solution thanks to your repro |
Describe the bug
I keep seeing the warning
programs.ruff.enable has been renamed to programs.ruff.check
But the thing is I am not even using ruff in my treefmt config.
To Reproduce
Not sure, whenever I am doing
nixos-rebuild
orhome-manager switch
I get it sometimes, but not when usingtreefmt-nix
vianix fmt
Expected behavior
If I am not using it, it shouldn't warn me.
System information
Additional context
Maybe just disable that in ruff.nix as a temporary fix. since it has been a while since the users were warned about it.
The text was updated successfully, but these errors were encountered: