Add packer fmt formatter
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that runs `packer fmt` on `*.pkr.hcl` and `*.pkrvars.hcl` files.
to (a) remove mention of the deleted `./bors.toml.sh`, (b) consistently render file names in monospace, (c) replace `nix develop -c treefmt` with `nix fmt`, and (d) provide some additional guidance on how to test the newly-introduced formatter.
zimbatm
reviewed
Mar 12, 2024
Done: hashicorp/packer#12883. |
|
Isn't this the same as |
|
probably. I would use |
Allegedly several of the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that
packer fmtaccepts only a single file or directory as an argument, this PR includes a not-particularly-pretty wrapper script that calls out topacker fmtonce per included source file, and a not-particularly-robust mechanism for distinguishing included source files frompacker fmtoptions (basically, trying to plop a bare--between options and source file arguments).Also includes some updates to the "Adding new formatters" section of the README; would be happy to spin these changes into a separate PR if that's preferable.
Thanks in advance!