yamlfmt: add options #193
Open
yamlfmt: add options #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
zimbatm
reviewed
Jul 20, 2024
| stringify = v: if lib.isBool v then lib.boolToString v else toString v; | ||
| in | ||
| lib.mapAttrsToList | ||
| (n: v: "-formatter=${n}=${stringify v}") |
There was a problem hiding this comment.
I think it would be best to generate the config file using the "settings" pattern and then pass it here with the -conf argument (if any settings are being set). The main reason is that the kernel limits the amount of argument a process can take, and we are using most of them for passing the list of files to format.
There was a problem hiding this comment.
Makes sense, will rework as soon as I find the time. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.