re-implement the core logic #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to remove the evaluation cache and parallel formatting for now in order to make this manageable. * Load the config * Prepare for filesystem traversal * Match each path against the formatters and collect the ones that match. Get the mtime from the traversal entry to avoid additional syscalls. * Now that we have a map from formatter to paths, run each formatter against its list. Collect a list of new mtimes. * Finally display the list of files that have changed.
Use OS-specific locations for the cache directory to make treefmt cross-platform.
zimbatm
force-pushed
the
refactor-xxx
branch
2 times, most recently
from
3c3f747 to
043bbcf
Compare
zimbatm
force-pushed
the
refactor-xxx
branch
from
043bbcf to
09d1d35
Compare
This is already handled by the formatter himself
Add more debugging. Take the baseline from ~500millis to ~60millis.
zimbatm
force-pushed
the
refactor-xxx
branch
from
7b52a1e to
c9bc5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement the core logic to get it right. I had to remove the evaluation cache and parallel formatting for now in order to make this manageable.