Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph black trail bug #1553

Merged
merged 4 commits into from
May 15, 2020

Conversation

LeaNumworks
Copy link
Collaborator

Fixes #1458

The problem only appeared on the device and was not on the macOS simulator due to the different values of FLT_EPSILON: 1e-5 on the device, around 1e-7 on the simulator.

Now the cursor cannot be on the edge of the graph view: panToMakePointVisible and addMargins change the X and Y ranges to put the cursor fully in the view.

@NumWorksBot
Copy link

.text .rodata .bss .data
Base 636 612 bytes 230 451 bytes 174 968 bytes 216 bytes
Head 636 556 bytes 230 451 bytes 174 968 bytes 216 bytes
- 56 bytes + 0 bytes + 0 bytes + 0 bytes
- 0 % + 0 % + 0 % + 0 %

@NumWorksBot
Copy link

.text .rodata .bss .data
Base 636 612 bytes 230 451 bytes 174 968 bytes 216 bytes
Head 636 556 bytes 230 451 bytes 174 968 bytes 216 bytes
- 56 bytes + 0 bytes + 0 bytes + 0 bytes
- 0 % + 0 % + 0 % + 0 %

@EmilieNumworks EmilieNumworks merged commit e7988b9 into numworks:master May 15, 2020
@LeaNumworks LeaNumworks deleted the FixGraphBlackTrailBug branch May 15, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black trail appears when function curve touches top of screen
3 participants