Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Add net5.0 support and remove out-of-support .NET Core versions #36

Closed
wants to merge 1 commit into from

Conversation

ViktorHofer
Copy link

@ViktorHofer ViktorHofer commented Mar 14, 2020

Contributes towards dotnet/sdk#10756

Adding net5.0 support (which lands in 5.0-preview2) and remove .NET Core
versions which aren't supported anymore: 1.0, 1.1, 2.0, 2.2, 3.0

cc @halex2005

This is blocked until .NET 5 Preview 2 is released (Travis) and a newer Visual Studio 2019 Preview image with it is released (AppVeyor).

Adding net5.0 support (which lands in 5.0-preview2) and remove .NET Core
versions which aren't supported anymore: 1.0, 1.1, 2.0, 2.2, 3.0
@halex2005
Copy link
Contributor

halex2005 commented Mar 16, 2020

Hi! Why would you like to remove .NET Core versions (from this template) which aren't supported anymore (by Microsoft)?
Not supported SDKs can be installed and I'd like to be able to create nunit csproj for any of target frameworks.

@ViktorHofer
Copy link
Author

Sure, I can revert the change which removes the out-of-support ones.

@halex2005
Copy link
Contributor

Thanks for contribution.
I'd like to add net5.0 support by myself, I'll take your PR as base. I think it would be simpler for you because both appveyor and travis check are failed for now, would you?

@halex2005
Copy link
Contributor

Closing this PR in favor of #37

@halex2005 halex2005 closed this Mar 26, 2020
@halex2005
Copy link
Contributor

halex2005 commented Mar 26, 2020

@ViktorHofer, in #37 I've fixed targeting. net5.0 is not supported by .NET 5 preview, but netcoreapp5.0 is supported. Do you set net5.0 intentionally or it was mistake?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants