Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ClrVersion from RuntimeFramework #1179

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Mar 31, 2022

Decision logic moved to Runtime class.

Fixes #1177

Decision logic moved to Runtime class.
@CharliePoole
Copy link
Member

Thanks for doing this. It's a nice simplification of the code.

Some of the methods in the RuntimeFramework and Runtime classes are oddly named, but they have been that way for a while. We should pay attention to naming when we replace the class. Especially: Matches vs Supports vs CanLoad!

FYI, The Azure build isn't intended to be running except for specially named branches right now, but it's not set up right so I'm just ignoring the failures till it's fixed.

@CharliePoole CharliePoole merged commit 100b434 into nunit:main Mar 31, 2022
@CharliePoole
Copy link
Member

Whoops... changed the issue fixed from #1176 to #1177

@tsmoreland
Copy link

any ETA on this being released? Or should we just be building a local version instead for a while?

@CharliePoole
Copy link
Member

If you mean this particular PR, it was merged and published on our myget feed as version 4.0.0-dev00102. Every time we merge a PR to main, we publish a -dev build. The feed is at https://www.myget.org/F/nunit/api/v3/index.json

If you mean "when will the final v4.0 be released?" I can't tell you that. There are too few of us working on it and our time availability is too variable to make a useful prediction. If you want to help, let me know. :-)

@tsmoreland
Copy link

-dev is fine, I've been using nunit3-console command line to run a test which has references to a wxiproj so can't use dotnet test directly, (maybe it's possible but use of nunit3-console was the faster solution), it's run as part of a CI pipeline which pulls down the command line tool to a fresh container, if I can get an update version from myget that'll work (I'll check that now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate need for CLR version in RuntimeFramework class
3 participants