Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version3: fix assembly dependecies resolver logic for netcore #1315

Closed
wants to merge 110 commits into from
Closed

Version3: fix assembly dependecies resolver logic for netcore #1315

wants to merge 110 commits into from

Conversation

svg2003
Copy link
Contributor

@svg2003 svg2003 commented Feb 12, 2023

Based on discussion
#1311

@CharliePoole
Recognize .NET 7 when installed
1f9eb7e
@CharliePoole
Update global.json
9b1284d
@CharliePoole
Merge pull request #1197 from nunit/issue-1193
a1bfef7 
Recognize .NET 7 when installed
@CharliePoole
Create dev release when merging into version3 branch
7dc0f03
@CharliePoole
Merge pull request #1198 from nunit/issue-1196
f2564da 
Create dev release when merging into version3 branch
@CharliePoole
Temporarily suppress publication step
e868668
@CharliePoole
Ensure that agent path is quoted when launching it
1814fda
@CharliePoole
Merge pull request #1207 from nunit/issue-1206
a55acb3 
Ensure that agent path is quoted when launching it
@CharliePoole
(Re)Fix issue 1178
aa6e34e
@CharliePoole
Merge pull request #1213 from nunit/issue-1178
80f67d0 
Re-fix issue 1178
@CharliePoole
Re-enable publish target commented out prviously
780dc6a
@CharliePoole
Add .NET 7.0 Agent
692a691
@CharliePoole
Install .NET 7.0 RC in AppVeyor
1ddaab4
@CharliePoole
Fix error in appveyor.yml
4ef2373
@CharliePoole
Don't run .Net 7.0 package tests for now
abb4994
@CharliePoole
Merge pull request #1220 from nunit/issue-1216b
b82f2a7 
Issue 1216b
@CharliePoole
Use registry to find Windows install directory
2bb2c7c
@CharliePoole
Display dotnet info in AppVeyor build
0d452f7
@CharliePoole
Split net core framework location functionality into a separate class
ad1c826
@CharliePoole
Recognize support for .NET core runtimes installed in path
aa4c43a
@CharliePoole
Re-enable package test under .NET 7.0
f54da34
@CharliePoole
Merge pull request #1222 from nunit/issue-941
0409a61 
Examine --list-runtimes in order to support adhoc install of .NET 7.0 RC on AppVeyor
@CharliePoole
Don't throw when an unknown / unsupported runtime is installed
b7f5ca4
@CharliePoole
Merge pull request #1226 from nunit/issue-1223
d59982b 
Don't throw when an unknown / unsupported runtime is installed
@CharliePoole
Include netcore 3.1 build in engine package once again
19d0bed
@CharliePoole
Merge pull request #1228 from nunit/issue-1225
9ad9140 
Include netcore 3.1 build in engine package once again
@CharliePoole
Install net 7.0
eb7428c
@CharliePoole
Merge pull request #1229 from nunit/azure-net70
fa0c761 
Install .NET 7.0 for Azure CI Build
@CharliePoole
Add Tests of TcpServer
4141251
@CharliePoole
Make TCP Listener thread a background thread
a31f520
CharliePoole and others added 25 commits December 3, 2022 11:00
@CharliePoole
Add missing file to NUnit.Engine package
92ed1bf
@CharliePoole
Merge pull request #1278 from nunit/issue-1275
9f3210e 
Add missing file to NUnit.Engine package
@CharliePoole
Handle exception when .NET Core is not installed
52c96e4
@CharliePoole
Merge pull request #1279 from nunit/issue-1277
6daf1c9 
Handle exception when .NET Core is not installed
@CharliePoole
Refactor scripts; represent each package by a separate class
a586d95
@CharliePoole
Separate build targets for each package
56c29e2
@CharliePoole
Use BuildSettings to pass options and arguements
0eb51df
@CharliePoole
Refactor scripts
ae3fcb5
@CharliePoole
Build full solution for local build under windows
f7ec62f
@CharliePoole
Merge pull request #1281 from nunit/issue-1271b
a1cc2dd 
Issue 1271b
@CharliePoole
Restore ability to debug packages
131ce0c
@CharliePoole
Merge pull request #1284 from nunit/package-debug
4a32d54 
Restore ability to debug packages
@CharliePoole
Resolve WindowsDesktop and AspNetCore tests correctly
fd47fcf
@CharliePoole
Changes from review
9c42495
@CharliePoole
Merge pull request #1285 from nunit/issue-1274
ef2055c 
Resolve WindowsDesktop and AspNetCore tests correctly
@CharliePoole
Use preinstalled .NET 7.0 SDK on AppVeyor
91c9f60
@CharliePoole
Merge pull request #1295 from nunit/issue-1294
2fe59e7 
Use pre-installed .NET 7.0 SDK on AppVeyor
@CharliePoole
Use NUnit-specific environment variable names
06447e4
@CharliePoole
Merge pull request #1298 from nunit/issue-1296
abc8668 
Use NUnit-specific environment variable names
@CharliePoole
Use x86 dotnet install path when running an x86 test assembly
477990c
@CharliePoole
Merge pull request #1304 from nunit/issue-1300
76330ac 
Use x86 dotnet install path when running an x86 test assembly
@OsirisTerje
Fix for #1307
155d902
@OsirisTerje
Not running when version is null
037e1b5
@OsirisTerje
Added check in calling method
3924b98
@OsirisTerje
Merge pull request #1309 from nunit/fixNullVersion
67fbaeb 
Fix for #1307
@dnfadmin
Copy link

dnfadmin commented Feb 12, 2023 •
edited
Loading

CLA assistant check
All CLA requirements met.

@CharliePoole
Copy link
Member

Why does this have 100 commits?... most of them old ones?

@CharliePoole CharliePoole mentioned this pull request Feb 12, 2023
Closed
@SeanKilleen
Copy link
Member

Hi @svg2003 it looks like rather than trying to merge in a PR you've done, this PR is attempting to merge the entirety of the version3 branch into the main branch. If you let me know what you're trying to accomplish, I might be able to help you, but since I don't see any commits you've authored here and it appears to be mistaken, I'm going to close it for the time being (but welcome you to open another one!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@svg2003 @dnfadmin @CharliePoole @SeanKilleen @OsirisTerje