Append user extensions #489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for starting this one off @nvborisenko. I think we need to do a little more design work on this one first, before we can start writing code. I'll comment back on the issue with my thoughts there. |
|
Hey @nvborisenko - thanks for putting this PR together. As discussed on the issue, I think we need to do some further spec work before we can take this one forward, so I'm going to close this PR for now. Thanks for the contribution - and hope it doesn't put you off contributing on other issues in the future! |
|
Sure. Created a PR to force a discussion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #488
I understand that this implementation is not good, hoping you will help. This solution works for me, but tests are failing.