Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Some Figure Shortcode Attributes Have No Effect #1112

Closed
gibru opened this issue Dec 10, 2023 · 5 comments
Closed

🐛 Some Figure Shortcode Attributes Have No Effect #1112

gibru opened this issue Dec 10, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@gibru
Copy link

gibru commented Dec 10, 2023

Describe the bug

When using the figure short code according to the example found in the documentation, multiple attributes have no effect, namely:

  1. href="https://mylink.com" (with nozoom=true): the image doesn't contain the link
  2. class: using custom.css with a class (.myclass) doesn't seem to have an affect when defined in shortcut (class="myclass"). This works with normal html/css (e.g. )
  3. defaut=true doesn't seem to have any effect at all

What works: src, caption, nozoom and alt

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser: Firefox, Chrome, Brave

Hugo & Blowfish versions
hugo v0.120.1 / blowfish 2.47.2

@qalldredge
Copy link

I see that the link works but even with nozoom=true it still zooms. It makes it awkward because the image will zoom and then the link is followed.

@gibru
Copy link
Author

gibru commented Feb 16, 2024

Yes, that is less than ideal. Without having to completely disable zoom, a workaround is to just use standard html and add the nozoom class to your img tag:

<a href="https://yourlink">
   <img class="nozoom" src="image source" ...>
</a>

@qalldredge
Copy link

Thank you. That works as a workaround.

@nunocoracao
Copy link
Owner

Sorry @gibru @qalldredge I'll take a look at this one. I probably messed something up in one of the last releases.

@nunocoracao nunocoracao self-assigned this Feb 17, 2024
@nunocoracao nunocoracao added the bug Something isn't working label Feb 17, 2024
@nunocoracao nunocoracao changed the title Some Figure Shortcode Attributes Have No Effect 🐛 Some Figure Shortcode Attributes Have No Effect Feb 17, 2024
nunocoracao added a commit that referenced this issue May 26, 2024
nunocoracao added a commit that referenced this issue May 26, 2024
ragibson pushed a commit to ragibson/blowfish-lite that referenced this issue Jul 29, 2024
ragibson pushed a commit to ragibson/blowfish-lite that referenced this issue Jul 29, 2024
@keesfluitman
Copy link

could it be that custom class in the shortcode has no effect yet? nozoom works. but class=customClass has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants