Gallery: Switch Packery to MagicGrid #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the Gallery shortcode to use MagicGrid instead of Packery. The main benefit is size (2.7k as opposed to 32k), and the results are mostly similar minus a few differences in image position.
StandingPadAnimations
changed the title
|
Hello @StandingPadAnimations not sure about this one. Changing a dependency like this can be a headache to maintain. I do like the decrease in size and also the fact that it seems more recent when compared to packery. I'll need time to pull your branch and see the differences. |
|
Reverting @StandingPadAnimations I don't like the final effect Packery Magic-grid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the
galleryshortcode to use MagicGrid instead of Packery. The main benefit is size, with MagicGrid being 2.7k, whereas Packery is 32k. The results are mostly similar minus a few differences in image position.