Remove unneeded files in lib/mermaid #1588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context: #980 (comment)
There was a finding that
assets/lib/mermaid
takes ~90MiB size. After digging the history a little, I am still curious why all files were included again:mermaid.min.js
until 7740790.package.json
along with many other filesHowever, after checking the code that includes mermaid:
blowfish/layouts/partials/vendor.html
Lines 6 to 10 in c6c2689
Looks like what we need here is only
mermaid.min.js
.Therefore I created this PR to remove the unneeded files and reduce the folder size from 90MiB to 3.3MiB.
This should benefit users using blowfish as hugo module and the ones who only shallow-clones the repo.
@nunocoracao please let me know if I missed anything.
Thanks!