Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fix that prevents the TOC from being covered by the main menu. #814

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

MaikelChan
Copy link
Contributor

The TOC can be partially hidden by the main menu when scrolling down if that menu has a logo image. That's even visible in the Blowfish page. Just to test that it wasn't a Windows thing, I also checked on Ubuntu and same result.

01

I adjusted the top value so the TOC never goes that high in the page when scrolling down.

02

@MaikelChan
Copy link
Contributor Author

MaikelChan commented Jul 14, 2023

I actually just found the proper fix.

It turns out there was a space in the " fixed" header layout type, so that check never returned true. That would set the lg:top-10 class when it should be lg:top-[140px] for fixed header layout. I also changed the condition to check if the layout type starts with "fixed", as the lg:top-[140px] class should be applied to all fixed layout variants (fixed, fixed-fill, fixed-fill-blur).

Thus, I reverted the CSS change.

I tested the changes with all header layout types and it works fine now.

@nunocoracao
Copy link
Owner

Thanks @MaikelChan

@nunocoracao nunocoracao changed the title Fix that prevents the TOC from being covered by the main menu. 🎨 Fix that prevents the TOC from being covered by the main menu. Jul 14, 2023
@nunocoracao nunocoracao merged commit 83a2471 into nunocoracao:dev Jul 14, 2023
@MaikelChan MaikelChan deleted the toc-position branch July 14, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants