-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env variable file added #29
Conversation
@@ -0,0 +1,11 @@ | |||
DOCKER_INFLUXDB_INIT_MODE=setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this has to be .env
? I would prefer test.env
or demo.env
.
.env
Outdated
DOCKER_INFLUXDB_INIT_RETENTION=1w | ||
DOCKER_INFLUXDB_INIT_BUCKET=telegraf | ||
DOCKER_INFLUXDB_INIT_ADMIN_TOKEN=quickbrownfoxjumpsoveralazydog | ||
NUOVERSION=5.0.1-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump this to a more recent version? I think 5.0.4 is the most recent version, but you should confirm.
You also don't need the patch builder number (-2
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that affect the product version that is used on the internal test server or it will be overwritten regardless of the version set here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will use the version set in the .env file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
No description provided.