feat: allow installer to pull the installerId from searchParams #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fidiego
force-pushed
the
fd/accept-installer-id-in-query-param
branch
from
64c971f
to
9b0faa9
Compare
this required a refactor of the root layout and modifications to the way
we handle `Metadata`.
- [ ] figure out how to use `searchParams` in the `generateMetadata`
- [ ] ensure the metadata is generated well regardless of what method we
use to get the installerId.
fidiego
force-pushed
the
fd/accept-installer-id-in-query-param
branch
from
9b0faa9
to
a97753b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the app to pull the
installerIdfrom the query params.Note: this required a refactor of the root layout and modifications to the way we handle
Metadata.These changes feel a little rough atm.
In effect, the root layout is now responsible solely for styles and generating metadata. the footer has been moved into the pages so we don't have to fetch the installer from the root layout.
TODO
searchParamsin thegenerateMetadata