Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/update ug tag #231

Open
wants to merge 702 commits into
base: master
Choose a base branch
from

Conversation

alexfoo-dw
Copy link

No description provided.

marvinchin and others added 30 commits November 1, 2017 01:02
Collate: Mark Codes + Add Collated sLoC Files (Marvin)
Feature: Enhance select command to allow specifying of social type
- Fixed default starting window width and height (a height just enough to view first 4 contacts and a width that provides a reasonable fit for the whole application)
- Fixed resizing of window going beyond allowable minimum width and height
- Decreased person card list width by 5 pixels
- Update UiTheme Singleton getInstance() method to be similar to EventCenter's method for consistency
-- Add UiFont singleton class and use it to load all the custom fonts
-- Pack all application required fonts into resources/fonts folder
-- Modify ThemeDay and ThemeNight to add sufficient padding between each field in person card
…-fonts

Fix: Embed fonts into the app for consistent typography across all platforms
… menu bar on different screen resolutions + (2) Fix window position shifting while resizing window from any menu bar area

-- Set root HBox to center align its nodes
-- Set root HBox to take a min and pref height of 45px + having a height higher than menu bar fixes the second issue
-- Set buttons to take the same min and pref height of 45px as it is on root HBox
-- Remove use of padding in CSS for buttons and menu bar since we're now using absolute height and width values in FXML (a better solution)
Fix: Align the height of window buttons to be the same as menu bar
- Fix unreadable dialog box colors
…o allow many more commands, allow null values for phone, email and address
KeithSOC and others added 28 commits November 13, 2017 20:05
…er-guide-sarah

Docs/DevGuide: Add sequence diagram for multiple phone numbers
Fix: Throw exception when selected person does not have requested social type
…s-keith

Docs/DeveloperGuide: Update for Keith's Features
@nus-se-pr-bot
Copy link

Hi @alexfoodw, your pull request title is invalid.

It should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants