[Barbaracwx] iP #67
Open
[Barbaracwx] iP #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limyuhching
reviewed
Sep 7, 2023
src/main/java/Task.java
Outdated
| return description; | ||
| } | ||
|
|
||
| public String getStatusIcon() { |
src/main/java/Task.java
Outdated
| return (isDone ? "X" : " "); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Good use of @OverRide to show overriding of parent's method
src/main/java/Duke.java
Outdated
| System.out.println("Nice! I've marked this task as done:\n" + tasks[taskIndex].toString()); | ||
| } | ||
| } else { | ||
| String[] parts = line.split(" ", 2); |
There was a problem hiding this comment.
Good use of plurality for naming "parts"
src/main/java/Duke.java
Outdated
| String command = parts[0]; | ||
| String taskDescription = parts.length > 1 ? parts[1] : ""; | ||
|
|
||
| switch (command) { |
There was a problem hiding this comment.
Right use of indentation for switch case
yicheng-toh
reviewed
Sep 7, 2023
src/main/java/DeadlineTask.java
Outdated
Comment on lines
1
to
2
| package PACKAGE_NAME;public class DeadlineTask { | ||
| } |
There was a problem hiding this comment.
You might want to add some spaces between the package and the class.
Suggested change
| package PACKAGE_NAME;public class DeadlineTask { | |
| } | |
| package PACKAGE_NAME; | |
| public class DeadlineTask { | |
| } |
src/main/java/Duke.java
Outdated
| case "event": | ||
| tasks[taskCount] = new EventTask(taskDescription); | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I like how you handle invalid inputs for the switch case.
src/main/java/Duke.java
Outdated
| String command = parts[0]; | ||
| String taskDescription = parts.length > 1 ? parts[1] : ""; | ||
|
|
||
| switch (command) { |
There was a problem hiding this comment.
Perhaps you could consider creating a separate method for the switch case
YongbinWang
reviewed
Sep 16, 2023
src/main/java/Duke.java
Outdated
| Task[] tasks = new Task[100]; | ||
| int taskCount = 0; | ||
|
|
||
| String line = input.nextLine(); |
There was a problem hiding this comment.
Consider changing your variable name to something more appropriate such as userInput.
Implement find
Added JavaDoc comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.